PR-118: add pathing metadata; fix metatype bug#118
Merged
cnuernber merged 1 commit intoSep 7, 2020
Conversation
jjtolton
changed the title
Contributor
Author
|
my laptop was melting down while recording that GIF ... the jumps aren't normally that slow 🤕 |
jjtolton
commented
Sep 4, 2020
jjtolton
commented
Sep 4, 2020
| (defn py-class-argspec [class] | ||
| (let [constructor (py/get-attr class "__init__")] | ||
| (py-fn-argspec constructor))) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
this function was defined (the same way) twice for some reason, so I removed the later one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #116
Editors that support "jump to source" can now jump to source using the metadata of Python functions, classes, modules, and methods instantiated via
require-python.Additionally, discovered a bug that prevented
socket.SocketIOfrom being interned withrequire-python, since it is neither a Python module nor Pythontype(it is anabc.meta). Put a generic exception wrapper with handling for metatypes.